Re: [PATCH 20/48] i18n: git-submodule die + eval_gettext messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 13, 2011 at 11:04, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote:
> On Fri, May 13, 2011 at 10:21 AM, Ãvar ArnfjÃrà Bjarmason
>> That's interesting. I thought that the problem would only be with
>> PATH, since we'd clobber the other environment variables when we do
>> the export in git-sh-i18n.
>>
>> But evidently not, but I don't quite grok why.
>>
>> Anyway, this behavior seems un-POSIX compliant, and I'd been assuming
>> that our shell scripts were POSIX shellscripts when I wrote this.
>
> May I remind you of the first rule in Documentation/CodingGuidelines?
>
> Â- Most importantly, we never say "It's in POSIX; we'll happily
> Â ignore your needs should your system not conform to it."
> Â We live in the real world.

I'm not saying we shouldn't work around it, I'll submit another series
which adds some unique prefix to all the environment variables.

I was just saying that I'd assumed that at least POSIX behavior for
environment variables could be relied upon.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]