On Tue, Apr 12, 2011 at 09:15, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Junio C Hamano <gitster@xxxxxxxxx> writes:
>
>> Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> writes:
>>
>>> Â Â Âfp = fopen(git_link, "w");
>>> Â Â Âif (!fp)
>>> - Â Â Â Â Â Âdie("Could not create git link %s", git_link);
>>> - Â Âfprintf(fp, "gitdir: %s\n", git_dir);
>>> + Â Â Â Â Â Âdie(_("Could not create git link %s"), git_link);
>>> + Â Âfprintf(fp, _("gitdir: %s\n"), git_dir);
>>> Â Â Âfclose(fp);
>>> ...
>> I don't think this is correct. ÂThe file "git_link" refers to .git that is
>> not a directory but is a regular file whose contents is "gitdir: $path"
>> and that should _never_ be localized, so the patch to die() message is Ok,
>> but the string given to fprintf(fp, ...) is _not_.
>
> See read_gitfile_gently() in setup.c; that is the reader of the
> information contained in this file.
Ah, thanks. Missed that. I'd have spotted it if I dug down instead of sending.
I'll re-send one without the translation for this plumbing message.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html