Re: [PATCH/RFC 1/7] i18n: mark init-db messages for translation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> writes:
>
>>  	fp = fopen(git_link, "w");
>>  	if (!fp)
>> -		die("Could not create git link %s", git_link);
>> -	fprintf(fp, "gitdir: %s\n", git_dir);
>> +		die(_("Could not create git link %s"), git_link);
>> +	fprintf(fp, _("gitdir: %s\n"), git_dir);
>>  	fclose(fp);
>> ...
> I don't think this is correct.  The file "git_link" refers to .git that is
> not a directory but is a regular file whose contents is "gitdir: $path"
> and that should _never_ be localized, so the patch to die() message is Ok,
> but the string given to fprintf(fp, ...) is _not_.

See read_gitfile_gently() in setup.c; that is the reader of the
information contained in this file.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]