Re: Git Rebase blows away GIT_AUTHOR_NAME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 14, 2011 at 11:21:45AM -0500, Jeff King wrote:

> So we should probably do one or both of:
> 
>   1. Make an --allow-any-name option to mailinfo, and use it when we
>      invoke mailinfo internally for rebasing. That still doesn't solve
>      the emailed patch problem, but at least keeps purely internal
>      operations sane.

So I wrote up a nice tidy patch series with mailinfo changes and tests,
and then am/rebase changes and tests on top of that. And guess what I
noticed? My rebase tests didn't actually fail with stock git.

I bisected to 43c2325 (am: use get_author_ident_from_commit instead of
mailinfo when rebasing, 2010-06-16), which was written to handle exactly
this sort of thing.

That commit made it into v1.7.2. JT, which version of git are you
running? Do you still see any problems with v1.7.2 and above? I can't
replicate your issue with more recent versions.

So unless we want to do any sort of commit-time warning, I don't think
there is anything left to be done on this topic.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]