On Fri, Dec 17, 2010 at 10:09 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes: > >>> I wonder if it makes more sense to change the type of revs->prune_data >>> from an array of pointers to strings to a pointer to struct pathspec. >>> Is there a downside? >> >> Converting a pointer to another pointer means mis typecasting can >> happen and the compiler won't help catching them. > > You can rename the field at the same time, and the compiler will catch > anything you forgot to touch, no? > Yes. I didn't think of that :( -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html