Re: [PATCH 14/21] Convert ce_path_match() to use struct pathspec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

>> I wonder if it makes more sense to change the type of revs->prune_data
>> from an array of pointers to strings to a pointer to struct pathspec.
>> Is there a downside?
>
> Converting a pointer to another pointer means mis typecasting can
> happen and the compiler won't help catching them.

You can rename the field at the same time, and the compiler will catch
anything you forgot to touch, no?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]