Thiago Farina wrote: > On Mon, Nov 29, 2010 at 2:57 PM, Jeremy Huddleston <jeremyhu@xxxxxxxxx> wrote: >> Signed-off-by: Jeremy Huddleston <jeremyhu@xxxxxxxxx> >> Reviewed-by: Matt Wright <mww@xxxxxxxxx> I like the idea, but could you add a short commit message explaining the existing behavior and what improvement this makes? > Why not #if defined(__APPLE__), like above? More importantly, please search for #ifdef in existing code to get some examples of how we like to do platform-specific things. The section "2) #ifdefs are ugly" of linux-2.6/Documentation/SubmittingPatches explains the rationale. Regards, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html