Re: [PATCH] Make the tab width used for whitespace checks configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Sixt wrote:

> Signed-off-by: Johannes Sixt <j6t@xxxxxxxx>
> ---
>  I have a project that uses tab width 4, and which has a lot of whitespace
>  errors. This is very helpful to spot them when lines are changed that
>  are indented with 4 spaces.

Thanks.

For what it's worth, I like the idea and the patch looks good.
(I haven't checked for missed spots or read the test in detail,
though.)

> +                       if (0 < tabwidth && tabwidth < 0100)
> +                               rule &= ~WS_TAB_WIDTH_MASK, rule |= tabwidth;

Tab widths are recognized with atoi and out-of-range tab widths are
silently ignored.  Could we help the user spot typos somehow?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]