On Nov 29, 2010, at 12:12, Jonathan Nieder wrote: > Thiago Farina wrote: >> On Mon, Nov 29, 2010 at 2:57 PM, Jeremy Huddleston <jeremyhu@xxxxxxxxx> wrote: > >>> Signed-off-by: Jeremy Huddleston <jeremyhu@xxxxxxxxx> >>> Reviewed-by: Matt Wright <mww@xxxxxxxxx> > > I like the idea, but could you add a short commit message > explaining the existing behavior and what improvement this makes? Hopefully what I resent is sufficient for explaining the changes. >> Why not #if defined(__APPLE__), like above? Originally for style. I like #ifdef better than #if defined(), but I changed it for you in the resend. > More importantly, please search for #ifdef in existing code to get > some examples of how we like to do platform-specific things. Yeah, I see some: #ifdef _WIN32 which is why I used __APPLE__. Do you have a better suggestion? > The section "2) #ifdefs are ugly" of > linux-2.6/Documentation/SubmittingPatches explains the rationale. I agree, but I don't really see a way around it here since this API is specific to OS X. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html