Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > This function can be potentially used in more places than just > tree-diff.c. "struct diff_options" does not make much sense outside > diff_tree_sha1(). > > Moreover people seem to be agree that diff machinery should learn > proper pathspecs too (i.e. globbing, negative pathspecs...), not just > treating pathspecs as tree prefix. There is nothing improper about the prefix match. Perhaps "richer"? I am not so sure about the need/desirability of negative match, but we will see. About naming. Where else other than "tree" (in the "hierarchical namespace" sense) context do you see pathspec? Does the struct really need to be called TREE_pathspec_list? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html