2010/9/15 Junio C Hamano <gitster@xxxxxxxxx>: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> This function can be potentially used in more places than just >> tree-diff.c. "struct diff_options" does not make much sense outside >> diff_tree_sha1(). >> >> Moreover people seem to be agree that diff machinery should learn >> proper pathspecs too (i.e. globbing, negative pathspecs...), not just >> treating pathspecs as tree prefix. > > There is nothing improper about the prefix match. Perhaps "richer"? > I am not so sure about the need/desirability of negative match, but we > will see. Negative match has been mentioned twice recently, once in Elijah's sparse clone [1] and once by a user [2]. [1] http://mid.gmane.org/AANLkTikJhSVJw2hXkp0j6XA+k-J-AtSYzKWumjnqqsgz@xxxxxxxxxxxxxx [2] http://mid.gmane.org/AANLkTikUadS+tj3ARdRqo=PSBVhTsJaUxaJv+=4hMf4s@xxxxxxxxxxxxxx > > About naming. Where else other than "tree" (in the "hierarchical > namespace" sense) context do you see pathspec? Does the struct really > need to be called TREE_pathspec_list? Pathspecs are usually stored in a list, const char ** and I don't want to take the generic name "pathspec_list", unless we convert all to use this struct. Any suggestions of other names? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html