On Wed, Aug 11, 2010 at 07:30, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > -test_expect_success 'status' ' > +test_expect_failure 'status' ' > ( > cd test && > git checkout b1 >/dev/null && Better to test_expect_success like my patch does and explicitly check the output, otherwise that test will pass if any part of it fails, e.g. if the checkout fails. Not likely, but it's more likely that the output will change again, in which case the grep tests I did would start failing again. It's good to have test canaries like that for important parts of our output. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html