Re: [PATCH 9/9] commit: suppress status summary when no changes staged

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason wrote:
> On Wed, Aug 11, 2010 at 07:30, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:

>> -test_expect_success 'status' '
>> +test_expect_failure 'status' '

Oops.  Did you see the follow-up patch?

> Better to test_expect_success like my patch does and explicitly check
> the output, otherwise that test will pass if any part of it fails,
> e.g. if the checkout fails.
>
> Not likely, but it's more likely that the output will change again, in
> which case the grep tests I did would start failing again.

The wt-status output series ought have included a separate test for
the new “git commit --dry-run” output.  But this is not what that test
script is about, and I think including it there would have been
confusing.

Sorry for the breakage, and thanks for reporting it.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]