Christian Couder wrote: > I don't know about sh -x but there is this code in test-lib.sh to warn about > GIT_TRACE use: > > case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z]") in > 1|2|true) > echo "* warning: Some tests will not work if GIT_TRACE" \ > "is set as to trace on STDERR ! *" > echo "* warning: Please set GIT_TRACE to something" \ > "other than 1, 2 or true ! *" > ;; > esac Oh! I just remembered http://thread.gmane.org/gmane.comp.version-control.git/146767 I guess the answer is we half-support it. Maybe a test_cmp_err() helper to strip out xtrace[1] and GIT_TRACE[2] output is needed. >> Summary: I was misled by the commit message. [...] > Ok, I will improve it. Thanks, and sorry for the unfocused review. Jonathan [1] Sadly, it is not obvious to me that the format of output produced by set -x is portable. Any sufficiently unixy system (e.g., any system supporting the Posix User Portability Utilities option) will use $PS4 which defaults to ‘+ ’ at the beginning of trace lines, but even for Posix that is only optional. [2] All trace output starts with ‘trace: ’, with one exception. diff --git a/exec_cmd.c b/exec_cmd.c index bf22570..75d2930 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -28,7 +28,7 @@ const char *system_path(const char *path) !(prefix = strip_path_suffix(argv0_path, BINDIR)) && !(prefix = strip_path_suffix(argv0_path, "git"))) { prefix = PREFIX; - trace_printf("RUNTIME_PREFIX requested, " + trace_printf("trace: RUNTIME_PREFIX requested, " "but prefix computation failed. " "Using static fallback '%s'.\n", prefix); } -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html