Hi, On Wednesday 14 July 2010 00:16:20 Jonathan Nieder wrote: > Christian Couder wrote: > > I don't know about sh -x but there is this code in test-lib.sh to warn > > about GIT_TRACE use: > > > > case $(echo $GIT_TRACE |tr "[A-Z]" "[a-z]") in > > > > 1|2|true) > > > > echo "* warning: Some tests will not work if GIT_TRACE" \ > > > > "is set as to trace on STDERR ! *" > > > > echo "* warning: Please set GIT_TRACE to something" \ > > > > "other than 1, 2 or true ! *" > > > > ;; > > > > esac > > Oh! I just remembered > > http://thread.gmane.org/gmane.comp.version-control.git/146767 > > I guess the answer is we half-support it. Maybe a test_cmp_err() > helper to strip out xtrace[1] and GIT_TRACE[2] output is needed. I don't understand the result of the above thread but when I try "bash -x t3508-cherry-pick-many-commits.sh" it works on my machine. So I didn't change the tests. > >> Summary: I was misled by the commit message. > > [...] > > > Ok, I will improve it. > > Thanks, and sorry for the unfocused review. No problem it's still better than no review :-) Thanks, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html