On Tue, Jul 13, 2010 at 15:48, Daniel F <nanotube@xxxxxxxxx> wrote:
> Ah yes, indeed... Well, is there any reason to even have that
> length sanity check in the first place? If someone wants to be
> identified with a nick of 1 or 2 chars, what's wrong with that?
I don't know. The whole thing seems a bit silly. I changed it:
- if (name->len < 3 || 60 < name->len || strchr(name->buf, '@')
||
+ if (name->len < 1 || 60 < name->len ||
strchr(name->buf, '@') ||
And nothing in the test suite broke. Removing the `name->len <' clause
completely broke one test in t5100-mailinfo.sh however.
But I don't understand that part of Git, maybe it really will break
horribly somewhere with:
Author: av <a@xxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html