On 7/13/10, Jay Soffian <jaysoffian@xxxxxxxxx> wrote:
> On Tue, Jul 13, 2010 at 10:54 AM, Daniel F <nanotube@xxxxxxxxx> wrote:
>> Apparently, git-am fails when the username is just one word.
>
> And is less than 3 characters.
>
> This is happening due to the get_sane_name check in mailinfo.c. The
> rules for a "sane" name are actually from Linus' original code. From
> 2744b23 (Start of early patch applicator tools for git., 2005-04-11):
>
> +static char *sanity_check(char *name, char *email)
> +{
> + int len = strlen(name);
> + if (len < 3 || len > 60)
> + return email;
> + if (strchr(name, '@') || strchr(name, '<') || strchr(name, '>'))
> + return email;
> + return name;
> +}
>
> You could add an option to mailinfo to disable the sanity check and
> then plumb that option into its various callers.
>
Ah yes, indeed... Well, is there any reason to even have that
length sanity check in the first place? If someone wants to be
identified with a nick of 1 or 2 chars, what's wrong with that?
I have approximately zero familiarity with various git internals,
so not sure if anything else depends on this length checkbeing there... But
if not, if it is essentially arbitrary... why add complexity with
extra options, instead of removing complexity by simply taking
out the minimum length check?
At any rate... seeing as how it is hard-coded at the moment,
I guess my immediate solution would be to discuss with my
patch submitter about choosing a longer nick :)
Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html