Re: [PATCH/RFC 0/2] git-svn: Allow certain refs to be ignored

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 20, 2010 at 4:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Michael Olson <mwolson@xxxxxxx> writes:
>
>> [svn-remote "svn"]
>>        url = https://svn.my.org/svn/root
>> ...
>>        ignore-refs = ^refs/remotes/(tags/)?old/myorg
>
> Traditionally configuration variable names are spelled camelCase without
> dashes.  You probably would want to be consistent.

I was looking at the existing syntax for "ignore-paths", which uses
dashes.  Should that be changed as well?

> Also "refs" and any pathname-like things are traditionally matched using
> globs and not regexes.  It is Ok to deviate if you have a strong reason to
> (and I suspect it would make it easier to write "exclude" patterns like
> the above example to allow a regex here), but that needs to be prominently
> documented (e.g. "Unlike any other ref-matching configuration variable,
> this alone uses regex, not glob") to avoid end user confusion.

ignore-paths also uses a regex.  I'm concerned that using globs will
not be expressive enough to represent a regex like (a combination of
the 2 use cases I posted initially):

^refs/remotes/((tags/)?old/myorg|old/bad_branch|old/unlabeled[^/]*|tags/(old/bad_tag|releases/another_tag))$

-- 
Michael Olson  |  http://mwolson.org/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]