Re: [PATCH/RFC 0/2] git-svn: Allow certain refs to be ignored

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Michael Olson <mwolson@xxxxxxx> writes:
> 
> > [svn-remote "svn"]
> >        url = https://svn.my.org/svn/root
> > ...
> >        ignore-refs = ^refs/remotes/(tags/)?old/myorg
> 
> Traditionally configuration variable names are spelled camelCase without
> dashes.  You probably would want to be consistent.

Configuration variables should definitely be camelCase in
examples/documentation (and I even dislike camelCase).  No dashes or
underscores here.

> Also "refs" and any pathname-like things are traditionally matched using
> globs and not regexes.  It is Ok to deviate if you have a strong reason to
> (and I suspect it would make it easier to write "exclude" patterns like
> the above example to allow a regex here), but that needs to be prominently
> documented (e.g. "Unlike any other ref-matching configuration variable,
> this alone uses regex, not glob") to avoid end user confusion.

I favor globs for more consistent/natural for path matching.

Another thing to keep in mind is that these would be Perl regular
expressions exposed to a user interface.  If git-svn were ever be
reimplemented in something other than Perl, PCRE (or similar) would be
required to interpret them consistently.

-- 
Eric Wong
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]