Hi, On Wed, 20 Jan 2010, Junio C Hamano wrote: > Subject: Fix "log" family not to be too agressive about showing notes > > Giving "Notes" information in the default output format of "log" and > "show" is a sensible progress (the user has asked for it by having the > notes), but for some commands (e.g. "format-patch") spewing notes into the > formatted commit log message without being asked is too aggressive. > > Enable notes output only for "log", "show", "whatchanged" by default; > other users can ask for it by setting show_notes field to true. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- Makes sense, and the patch actually removes what could be seen as an ugly side effect (why it only ONELINE not getting notes?). I would agree with Peff about the mention of --pretty disabling notes (unless asked for by a user format) in the commit notes as well as in the pretty options, but I fully disagree on the need for tests. We should not have a thorough test suite that runs for days on end, but we should concentrate on things that are more likely to get broken. And the added code is just too obvious for that. (Anybody remember the initial suggestion for testing git-commit before making it builtin? It had something like 70 tests.) Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html