On 20.01.2010 20:23, Ramsay Jones wrote:
> '-o' or connective. This resulted in the buildsystem generator
> mistaking the conditional 'rm' for a linker command. In order
Thanks for spotting the cause of this! Some comments:
1. How about deleting lines 183-185 in same run? That commented out
code, too, is missing the escapes for the pipes that Pete mentioned anyway.
-# } elsif ($text =~ /^test / && $text =~ /|| rm -f /) {
-# # commands removing executables, if they exist
-#
2. Couldn't we reduce the test to just
+ if ($text =~ /^test /) {
+ # options to test may be mistaken for linker options
+ next;
+ }
+
3. If the above won't do for some reason, I'd still prefer something like
+ if ($text =~ /^test / && $text =~ / -o /) {
+ # options to test may be mistaken for linker options
+ next;
+ }
+
as it makes more clear what's the problem in such lines.
--
Sebastian Schuberth
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html