On 2009-09-09 23:09:51 +0100, Catalin Marinas wrote:
> 2009/9/8 Karl Wiberg <kha@xxxxxxxxxxx>:
>
> > On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote:
> >
> > > + if strip:
> > > + cmd += ['-p', strip]
> >
> > This test should probably be "if strip != None". It doesn't
> > _really_ matter, technically, since -p0 is the default, but still
> > ...
>
> I modified it after posting the patch. The git default is -p1, so we
> would miss the -p0 case.
Ah ha! Sometimes it actually does pay to be pedantic ...
--
Karl Wiberg, kha@xxxxxxxxxxx
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html