2009/9/8 Karl Wiberg <kha@xxxxxxxxxxx>: > On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote: > >> This patch renames some of the existing import options and adds the >> -p (--strip) option which allows stripping the leading slashes of >> the diff paths. > > Looks good (and the intent is very good). The import test should > probably be augmented with a test case for -pN, though. Yes. I'll try to add one. As you noticed, not all options are tested. >> + if strip: >> + cmd += ['-p', strip] > > This test should probably be "if strip != None". It doesn't _really_ > matter, technically, since -p0 is the default, but still ... I modified it after posting the patch. The git default is -p1, so we would miss the -p0 case. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html