On 2009-09-08 22:43:39 +0100, Catalin Marinas wrote:
> This patch renames some of the existing import options and adds the
> -p (--strip) option which allows stripping the leading slashes of
> the diff paths.
Looks good (and the intent is very good). The import test should
probably be augmented with a test case for -pN, though. (And since you
didn't have to change the test in this patch, presumably the two
options you renamed weren't tested either.)
> + if strip:
> + cmd += ['-p', strip]
This test should probably be "if strip != None". It doesn't _really_
matter, technically, since -p0 is the default, but still ...
--
Karl Wiberg, kha@xxxxxxxxxxx
www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html