Re: [PATCH] git fast-export: add --no-data option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 25 Jul 2009, Junio C Hamano wrote:

> Geoffrey Irving <irving@xxxxxxx> writes:
> 
> > @@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,
> > const char *prefix)
> >  			     "Import marks from this file"),
> >  		OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
> >  			     "Fake a tagger when tags lack one"),
> > +		OPT_BOOLEAN(0, "no-data", &no_data,
> > +			     "Skip output of blob data"),
> 
> Shouldn't this be --[no-]data option that defaults to true?  Otherwise you
> would accept --no-no-data that looks silly.

Maybe

		OPT_NEGBIT(0, "data", &no_data,
			     "Skip output of blob data", 1),

Hmm?

Ciao,
Dscho
		
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]