Hi, On Sat, 25 Jul 2009, Alex Vandiver wrote: > At Sat Jul 25 10:09:56 -0400 2009, Johannes Schindelin wrote: > > Is this not unnecessary, given that we only call that function when we > > know that buf[0] == '[': > > Yes. However, given that I had changed the calling convention for the > code, (it used to be passed the string starting just _inside_ the > '['), I wanted to make the new calling convention clearer, and catch > any places that were using the old convention. > > I'm happy to submit a new version without it, if you wish. > > > I was a bit surprised that "offset" is not used further in your patch, but > > I saw that 2/2 uses it. > > Yeah, this hunk should probably have gone in 2/2 instead. No need to change anything, Junio already applied your patches. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html