On Sat, Jul 25, 2009 at 1:44 PM, Johannes
Schindelin<Johannes.Schindelin@xxxxxx> wrote:
> Hi,
>
> On Sat, 25 Jul 2009, Junio C Hamano wrote:
>
>> Geoffrey Irving <irving@xxxxxxx> writes:
>>
>> > @@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,
>> > const char *prefix)
>> > "Import marks from this file"),
>> > OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
>> > "Fake a tagger when tags lack one"),
>> > + OPT_BOOLEAN(0, "no-data", &no_data,
>> > + "Skip output of blob data"),
>>
>> Shouldn't this be --[no-]data option that defaults to true? Otherwise you
>> would accept --no-no-data that looks silly.
>
> Maybe
>
> OPT_NEGBIT(0, "data", &no_data,
> "Skip output of blob data", 1),
>
> Hmm?
Not quite. That produces
usage: git fast-export [rev-list-opts]
--progress <n> show progress after <n> objects
--signed-tags <mode> select handling of signed tags
--export-marks <FILE>
Dump marks to this file
--import-marks <FILE>
Import marks from this file
--fake-missing-tagger
Fake a tagger when tags lack one
--data Skip output of blob data
I don't see similar uses of OPT_NEGBIT, so maybe the necessary option
case hasn't been written yet (or I'm missing something obvious)?
Geoffrey
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html