On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
> 2009/6/30 Jakub Narebski <jnareb@xxxxxxxxx>:
>> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
# prints time in local timezone, from result of parse_date
# in the following format: " (HH:MM +/-tz_offset)" or " (%H:%M %z)"
# with "atnight" warning when 0 <= hour_local < 6
or something like that. Or just
# prints time in local timezone, from result of parse_date
>>> +sub print_local_time {
>>> + my %date = @_;
>>> + if ($date{'hour_local'} < 6) {
>>> + printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>>> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>>> + } else {
>>> + printf(" (%02d:%02d %s)",
>>> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>>> + }
>>> +}
>>
>> Very nice refactoring.
>>
>> It could do with a comment describing its output, but it is not
>> necessary, and IMHO not worth resend. We can always add it "in tree".
>
> Damn! I was sure I'd forget something ...
Don't worry. It can be always addd later, or Junio can just squash
proposed comment (see above).
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html