Re: [PATCHv8 1/7] gitweb: refactor author name insertion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2009/6/30 Jakub Narebski <jnareb@xxxxxxxxx>:
> On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
>> +sub print_local_time {
>> +     my %date = @_;
>> +     if ($date{'hour_local'} < 6) {
>> +             printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> +     } else {
>> +             printf(" (%02d:%02d %s)",
>> +                     $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>> +     }
>> +}
>
> Very nice refactoring.
>
> It could do with a comment describing its output, but it is not
> necessary, and IMHO not worth resend.  We can always add it "in tree".

Damn! I was sure I'd forget something ...

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]