On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
> Collect all author display code in appropriate functions, making it
> easier to extend these functions on the CGI side.
>
> We also move some of the presentation code from hard-coded HTML to CSS,
> for easier customization.
>
> A side effect of the refactoring is that now localtime is always
> displayed with the 'at night' warning.
It is a very nice side effect, I think.
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
Acked-by: Jakub Narebski <jnareb@xxxxxxxxx>
> ---
> gitweb/gitweb.css | 5 ++-
> gitweb/gitweb.perl | 93 ++++++++++++++++++++++++++++++---------------------
> 2 files changed, 59 insertions(+), 39 deletions(-)
[...]
> +sub print_local_time {
> + my %date = @_;
> + if ($date{'hour_local'} < 6) {
> + printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
> + } else {
> + printf(" (%02d:%02d %s)",
> + $date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
> + }
> +}
Very nice refactoring.
It could do with a comment describing its output, but it is not
necessary, and IMHO not worth resend. We can always add it "in tree".
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html