On Tue, 30 Jun 2009, Giuseppe Bilotta wrote:
> Switch from 'log'-like layout
>
> A U Thor <email@xxxxxxxxxxx> [date time]
>
> to 'commit'-like layout
>
> author A U Thor <email@xxxxxxxxxxx>
> date time
> committer C O Mitter <other.email@xxxxxxxxxxx>
> committer date time
>
> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx>
I am (as I have said earlier) a bit ambivalent about this issue.
But I like this patch from technical point of view.
I also like the fact that this feature is put in separate patch,
so it can be accepted or rejected (or reverted) independently.
Good work on refactoring!
Techically-Acked-By: Jakub Narebski <jnareb@xxxxxxxxx>
> ---
> gitweb/gitweb.perl | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 7fd53f6..9a8d775 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5596,7 +5596,11 @@ sub git_commitdiff {
> git_header_html(undef, $expires);
> git_print_page_nav('commitdiff','', $hash,$co{'tree'},$hash,
$formats_nav);
> git_print_header_div('commit', esc_html($co{'title'}) . $ref,
$hash);
> - git_print_authorship(\%co, -localtime => 1);
> + print "<div class=\"title_text\">\n" .
> + "<table class=\"object_header\">\n";
> + git_print_authorship_rows(\%co);
> + print "</table>".
> + "</div>\n";
> print "<div class=\"page_body\">\n";
> if (@{$co{'comment'}} > 1) {
> print "<div class=\"log\">\n";
> --
> 1.6.3.rc1.192.gdbfcb
>
>
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html