Hi. On Sat, 18 Apr 2009, Keith Cascio wrote: > On Sat, 18 Apr 2009, Johannes Schindelin wrote: > > > And I still do not like the intrusiveness of your patch. The last > > time we did something like that with options (some > > parseoptifications), we had a lot of fallout as a consequence. > > [...] > > Peff expressed some specific concerns [...] My concerns were also very specific: your patches are way too large. There is a rule of thumb that the likelihood of a bug is the square of the number of changed lines, I am sure you heard that before. > [...] your patch adds at least ten lines outside of diff.h/diff.c. That is _such_ a red herring. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html