Hi, On Thu, 16 Apr 2009, Jeff King wrote: > On Tue, Apr 14, 2009 at 12:37:42AM +0200, Johannes Schindelin wrote: > > > > 1. You could loosen (1) above by assuming that --no-defaults will > > > never appears as the argument to an option, and therefore any time > > > you find it, it should be respected. Thus your first parse is just > > > a simple loop looking for the option. > > > > I go with 1) > > This feels very hack-ish to me, but perhaps this is a case of "perfect > is the enemy of the good". I have a strong feeling that none of our diff/rev options can sanely take a parameter looking like "--defaults" or "--no-defaults". But I do not have the time to audit the options. Maybe you have? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html