Jakub Narebski <jnareb@xxxxxxxxx> writes:
> Could you use full hex color length? Everywhere else in CSS we use
> 6-char wide hex colours.
Will do for consistency's sake, although I do not think we
really care about the extra precision in this application.
> We have age_class subroutine which does something similar.
Yeah, but...
(1) When somebody says "there are three age classes: age0,
age1, and age2", can you tell which one represents older
ones? I think they are misnamed.
(2) The classification of age_class seems to be useful for the
project age, which is to check if anything happened in the
last two hours and last two days. Unless the project is
really dead/dormant it should not be more than a month. On
the other hand, a mature and stable project should have
more than 80% lines that are more than a year old, even if
it is very active and have many lines that are less than
two hours old.
The yardstick age_class uses is really geared toward
checking project's last activity and not appropriate for
use in blame. Luckily, blame2 does not use it.
(3) I'd like to eventually get rid of the abbreviated commit
object name from blame output, so the setting in gitweb.css
for table.blame td.age[012] (different colors and font
styles) is not appropriate for what I am shooting at.
I have a bit updated 3-series for review.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html