Linus Torvalds wrote:
> I've got _one_ small beef with gitweb still, which is that it seems to
> like always showing things in UTC rather than the "native" timezone, but I
> can see why people would sometimes want that. So I'm not actually sure
> it's wrong.
>
> I think it _may_ be worth showing the native timezone in the "commit-diff"
> view (when you see only one commit), and then show the UTC time in the
> "log" view (when you see a lot of commits, and might want to compare times
> in different timezones more easily).
>
> But I think that timezone thing is probably a matter of taste rather than
> much anything else.
-- >8 --
Add local time (hours and minutes) and local timezone to the output of
git_print_authorship command, used by git_commitdiff. The code was
taken from git_commit subroutine.
Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
---
gitweb/gitweb.perl | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index ef09cf5..fa7f62a 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1345,10 +1345,18 @@ #sub git_print_authorship (\%) {
sub git_print_authorship {
my $co = shift;
- my %ad = parse_date($co->{'author_epoch'});
+ my %ad = parse_date($co->{'author_epoch'}, $co->{'author_tz'});
print "<div class=\"author_date\">" .
esc_html($co->{'author_name'}) .
- " [$ad{'rfc2822'}]</div>\n";
+ " [$ad{'rfc2822'}";
+ if ($ad{'hour_local'} < 6) {
+ printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
+ $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'});
+ } else {
+ printf(" (%02d:%02d %s)",
+ $ad{'hour_local'}, $ad{'minute_local'}, $ad{'tz_local'});
+ }
+ print "]</div>\n";
}
sub git_print_page_path {
--
1.4.1.1
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html