Junio C Hamano wrote:
> Jakub Narebski <jnareb@xxxxxxxxx> writes:
>
>> Add local time (hours and minutes) and local timezone to the output of
>> git_print_authorship command, used by git_commitdiff.
>
> Looks nice, thanks.
>
> Now I got envious seeing people are having SO MUCH FUN with
> gitweb, so here is mine...
>
> Likes, dislikes, "your color selection sucks ;-)",... ?
>
> -- >8 --
> +td.age-week { color: #00f; background-color: #fff; }
> +td.age-month { color: #00f; background-color: #eef; }
> +td.age-season { color: #00f; background-color: #ddf; }
> +td.age-year { color: #00f; background-color: #ccf; }
> +td.age-old { color: #00f; background-color: #bbf; }
Could you use full hex color length? Everywhere else in CSS we use
6-char wide hex colours.
> + my $now = time();
> while (<$fd>) {
> - /^([0-9a-fA-F]{40}).*?(\d+)\)\s{1}(\s*.*)/;
> - my $full_rev = $1;
> + my ($full_rev, $author, $timestamp, $zone, $lineno, $data) =
> + /^([0-9a-fA-F]{40})\s\((.*?)\s+(\d+)\s
> + ([-+\d]{5})\s+(\d+)\)\s{1}(\s*.*)/x;
Nice compact style. But different from other parsing using regexp in gitweb.
And some of those other, e.g. parse_difftree_raw_line cannot use this style.
Doesn't matter much.
> my $rev = substr($full_rev, 0, 8);
> - my $lineno = $2;
> - my $data = $3;
> +
> + my $age = $now - $timestamp;
> + my $ago = age_string($age);
> + my $pop = "$author, $ago";
> + my $agegroup =
> + (($age < 60*60*24*7) ? "age-week" :
> + ($age < 60*60*24*30) ? "age-month" :
> + ($age < 60*60*24*120) ? "age-season" :
> + ($age < 60*60*24*360) ? "age-year" : "age-old");
We have age_class subroutine which does something similar.
I'm not sure if one subroutine can be used for those two situations.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html