Re: [Gimp-developer] there is hope for gimp-perl-1.3 (was: red-eye-removal)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 16, 2003 at 09:57:48PM +0200,  Marc A. Lehmann  wrote:
> > > > http://fmg-www.cs.ucla.edu/fmg-members/geoff/digicam/redeye
> 
> Woaw, a PDL plug-in not written by me! Oh my god, I can't believe it
> happened ;)

Yep, though the author missed the whole point of PDL by looping 
over x and y.

Instead of the loop the following code would have done the same thing
much faster.

   $rbrite = $data(0,:,:)* 0.5133333;
   $gbrite = $data(1,:,:);
   $bbrite = $data(2,:,:)*0.193333;
   $r = (($gbrite+$bbrite)/2/0.513333)->clip(0,255)->byte;
   $mask = ($rbrite >= $gbrite - $threshold) & ($rbrite>=$bbrite - $threshold);
   $data(0,:,:) .= $mask * $r + (1-$mask)*$data(0,:,:);

using the NiceSlice syntax. But it really doesn't make it any more
legible... (It doesn't even look like perl...)

(Btw, I wonder if you couldn't use the PDL implicit threading model to loop 
over the tiles implicitely... Now I'm getting carried away.)

> On Mon, Jun 16, 2003 at 09:54:42AM -0400, Carol Spears <cspears@xxxxxxxxxxxxxx> wrote:
> > perl ported to gimp-1.3 and the plug-ins as well.
> 
> One thing of interest is that I am currently working my way through the
> Gtk2 module(s) available for perl. Apart from some things I'd really like
> to have changed and settled to make use of it, this was the major obstacle
> to a gimp-perl-1.3.

Actually, I ported all the non-gui stuff already, which was really quite
straight forward. I then started looking at perl-gtk-xs. What got me 
stuck is the fact that you created the various widgets by inheritance 
and perl-gtk-xs still doesn't support inheriting gtk widgets on the perl
level. I'd be happy to send you the stuff that I have, but I really don't
think that you need it.
 
> Ok, that was a lie, the major obstacle was my lack of time, but now I
> don't have any other good excuses anymore. It might still take months, but
> at least I'd like to let you know that I am working on gimp-perl again,
> even if it's only "getting used to the Gtk2 internals".
> 
> (Gtk2 looks quite good already, btw..)

It sure does. :-)

Regards,
Dov

[Index of Archives]     [Video For Linux]     [Photo]     [Yosemite News]     [gtk]     [GIMP for Windows]     [KDE]     [GEGL]     [Gimp's Home]     [Gimp on GUI]     [Gimp on Windows]     [Steve's Art]

  Powered by Linux