Hello!
The bug reported by Gernot Ziegler
(problems saving jpeg with GAP)
is located in the "gimp_file_save"
procedure. A bugfix is attached to this mail.
attach: diff.fileops_cmds.c.gz (508 bytes)
(because i have no access to the CVS i asked
Sven Neumann to apply the bugfix and some
improvements to GAP in context with gimp_file_save
but he is busy with implementing new features
so it'll take a few days.)
The problem came up with the type-check
of the PDB-Parameters before execution.
My bugfix sets the requested arg_types
for all file_save_plugin specific
parameters (args[5] upto args[n]) in the
gimp-file_save_invoker.
I also generate a pointer to an
empty string on STRING args.
(if a null pointer is passed
to the file_jpeg_save procedure
it will also crash, and other
may have the same problem)
Suggestion: There should be
default values for some or all
of the individual parameters of file-save
procedures. for now al individual
params are cleared to zero.
In case of jpeg that means quality 0.0
when called in NONINTERACTIVE runmode
(that will not satisfy any user)
One idea to implement defaults
could look like this:
jpeg.c:
query()
{
static gdouble default_quality = 0.75;
gimp_set_data ("file_jpeg_save:default:quality",
&default_quality,
sizeof(default_quality));
......
}
the changes to GAP, (mentioned above)
are replacing the NONINTERACTIVE
runmode by an INTERACTIVE call
(at first handled frame) and
the RUN_WITH_LAST_VALUES mode
for all subsequent frames.
Yours, Wolfgang Hofer <hof@xxxxxxxxxx>
(author of GAP)
HotBot - Search smarter.
http://www.hotbot.comAttachment:
diff.fileops_cmds.c.gz
Description: GNU Zip compressed data
