Re: visitable_needs_visiting

[Henrik Akesson <h.m.akesson@xxxxxxxxx>]

>From where I come from, it's a no-no to keep unused code "just in case". Normally, this kind of code tends to accumulate and never be cleaned out. On top of that, the "just in case" code tends to have to be rewritten when finally needed, as it is seldom fit for the purpose (the imagined case is often not the real case).

But, all that said, if you like to keep it, I'll respect that.

Henrik

2009/3/13 Martin Nordholts <enselic@xxxxxxxxx>

Henrik Akesson wrote:
> The two implementations of GeglVisitable always returns TRUE on calls
> to "visitable_needs_visiting" (see gegl-node:957 and gegl-pad:319).
>
> It is used by gegl-visitor.c, but makes it more difficult to
> understand the code.
>
> Can I remove it?

I think you should keep it. It doesn't make the code extremely more
complicated and keeps the door open for optimizations

- Martin

_______________________________________________
Gegl-developer mailing list
Gegl-developer@xxxxxxxxxxxxxxxxxxxxxx
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gegl-developer