On Thu, Mar 13, 2025 at 08:28:09AM +0100, Christoph Hellwig wrote: > On Wed, Mar 12, 2025 at 01:23:14PM -0700, Darrick J. Wong wrote: > > > for opt in uquota gquota pquota; do > > > @@ -2074,6 +2080,11 @@ _scratch_xfs_force_no_metadir() > > > if grep -q 'metadir=' $MKFS_XFS_PROG; then > > > MKFS_OPTIONS="-m metadir=0 $MKFS_OPTIONS" > > > fi > > > + > > > + # zoned requires metadir > > > + if grep -q 'zoned=' $MKFS_XFS_PROG; then > > > + MKFS_OPTIONS="-m zoned=0 $MKFS_OPTIONS" > > > > I think this cause mkfs to fail due to the respecification of -mzoned > > if MKFS_OPTIONS originally had -mzoned= in it? > > Hmm, don't we allow respecification to override earlier settings? Nope: $ mkfs.xfs -f -m rmapbt=0 -m rmapbt=1 /tmp/a -m rmapbt option respecified <snip> You can't even override the options specified in a config file: $ mkfs.xfs -f -c options=/usr/share/xfsprogs/mkfs/lts_5.4.conf -m rmapbt=1 /tmp/a -m rmapbt option respecified > Let me double check the _scratch_xfs_force_no_metadir tests on > zoned on conventional runs. --D
