Re: [PATCH 11/17] xfs: handle zoned file systems in _scratch_xfs_force_no_metadir

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Mar 12, 2025 at 01:23:14PM -0700, Darrick J. Wong wrote:
> >  	for opt in uquota gquota pquota; do
> > @@ -2074,6 +2080,11 @@ _scratch_xfs_force_no_metadir()
> >  	if grep -q 'metadir=' $MKFS_XFS_PROG; then
> >  		MKFS_OPTIONS="-m metadir=0 $MKFS_OPTIONS"
> >  	fi
> > +
> > +	# zoned requires metadir
> > +	if grep -q 'zoned=' $MKFS_XFS_PROG; then
> > +		MKFS_OPTIONS="-m zoned=0 $MKFS_OPTIONS"
> 
> I think this cause mkfs to fail due to the respecification of -mzoned
> if MKFS_OPTIONS originally had -mzoned= in it?

Hmm, don't we allow respecification to override earlier settings?
Let me double check the _scratch_xfs_force_no_metadir tests on
zoned on conventional runs.





[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux