On Wed, Mar 12, 2025 at 01:25:11PM -0700, Darrick J. Wong wrote:
> > # apply to any scratch fs that might be created.
> > _require_xfs_rtquota_if_rtdev() {
> > - test "$USE_EXTERNAL" = "yes" || return
> > + if [ "$USE_EXTERNAL" != "yes" ]; then
> > + xfs_info "$TEST_DIR" | grep -q 'realtime.*internal' &&
> > + _notrun "Quota on internal rt device not supported"
>
> Huh, I wonder if we should've allowed internal non-zoned rt devices.
> It might've made the whole "we want 2MB blocksize on pmem" mess a little
> less unpalatable.
The code should be able to easily support it, but we'd need a new
feature flag to look for the rtstart value. We can probably just add
that feature the next time we add a somewhat relevant feature flag.
Hopefuly until then we'll support quotas on zoned so this check can
go away. Of maybe we just need to find a better way to probe for
quota support in general as the checks in xfstests are a bit of a
mess.
