On Wed, Mar 12, 2025 at 07:45:04AM +0100, Christoph Hellwig wrote:
> Same as regular zoned, but the previous check didn't work.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> common/xfs | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/common/xfs b/common/xfs
> index a18b721eb5cf..3f9119d5ef65 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -2210,7 +2210,10 @@ _xfs_scratch_supports_rtquota() {
> # can check that quickly, and we make the bold assumption that the same will
> # apply to any scratch fs that might be created.
> _require_xfs_rtquota_if_rtdev() {
> - test "$USE_EXTERNAL" = "yes" || return
> + if [ "$USE_EXTERNAL" != "yes" ]; then
> + xfs_info "$TEST_DIR" | grep -q 'realtime.*internal' &&
> + _notrun "Quota on internal rt device not supported"
Huh, I wonder if we should've allowed internal non-zoned rt devices.
It might've made the whole "we want 2MB blocksize on pmem" mess a little
less unpalatable.
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
--D
> + fi
>
> if [ -n "$TEST_RTDEV$SCRATCH_RTDEV" ]; then
> _xfs_kmod_supports_rtquota || \
> --
> 2.45.2
>
>
