Re: [PATCH 15/17] xfs: skip various tests on zoned devices

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Mar 13, 2025 at 08:32:18AM +0100, Christoph Hellwig wrote:
> On Wed, Mar 12, 2025 at 01:27:59PM -0700, Darrick J. Wong wrote:
> > > +# The dm-delay map added by this test doesn't work on zoned devices
> > > +_require_non_zoned_device $SCRATCH_DEV
> > 
> > Should this kind of check become a part of _require_dm_target?  Or does
> > dm-delay support zoned targets, just not for this test?
> 
> i.e. check for specific targets in _require_dm_target and reject them
> on zoned?  I can see if that would work.

Yeah, since it already switches on which target you ask for, and applies
per-target requirements checking.

--D

> > > +#
> > > +# The dm-flakey map added by this test doesn't work on zoned devices
> > > +# because table sizes need to be aligned to the zone size.
> > > +#
> > > +_require_non_zoned_device $SCRATCH_DEV
> > > +_require_non_zoned_device $SCRATCH_RTDEV
> > 
> > Can we fix the table sizes?
> 
> I'll take a look.
> 
> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux