Re: [PATCH] fstests: btrfs add more tests into the scrub group

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Sep 14, 2023 at 07:24:57AM +0800, Anand Jain wrote:
> 
> 
> On 9/14/23 00:33, Zorro Lang wrote:
> > On Tue, Aug 29, 2023 at 08:32:40PM +0800, Anand Jain wrote:
> > > I wanted to verify tests using the command "btrfs scrub start" and
> > > found that there are many more test cases using "btrfs scrub start"
> > > than what is listed in the group.list file. So, get them to the scrub
> > > group.
> > > 
> > > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
> > > ---
> > >   tests/btrfs/011 | 2 +-
> > >   tests/btrfs/027 | 2 +-
> > >   tests/btrfs/060 | 2 +-
> > >   tests/btrfs/062 | 2 +-
> > >   tests/btrfs/063 | 2 +-
> > >   tests/btrfs/064 | 2 +-
> > >   tests/btrfs/065 | 2 +-
> > >   tests/btrfs/067 | 2 +-
> > >   tests/btrfs/068 | 2 +-
> > >   tests/btrfs/069 | 2 +-
> > >   tests/btrfs/070 | 2 +-
> > >   tests/btrfs/071 | 2 +-
> > >   tests/btrfs/074 | 2 +-
> > >   tests/btrfs/148 | 2 +-
> > >   tests/btrfs/195 | 2 +-
> > >   tests/btrfs/261 | 2 +-
> > >   16 files changed, 16 insertions(+), 16 deletions(-)
> > > 
> > > diff --git a/tests/btrfs/011 b/tests/btrfs/011
> > > index 852742ee8396..ff52ada94a17 100755
> > > --- a/tests/btrfs/011
> > > +++ b/tests/btrfs/011
> > > @@ -20,7 +20,7 @@
> > >   # performed, a btrfsck run, and finally the filesystem is remounted.
> > >   #
> > >   . ./common/preamble
> > > -_begin_fstest auto replace volume
> > > +_begin_fstest auto replace volume scrub
> > >   noise_pid=0
> > 
> > [snip]
> > 
> > >   # Import common functions.
> > >   . ./common/filter
> > > diff --git a/tests/btrfs/069 b/tests/btrfs/069
> > > index 6e798a2e5061..824ca3c3110b 100755
> > > --- a/tests/btrfs/069
> > > +++ b/tests/btrfs/069
> > > @@ -8,7 +8,7 @@
> > >   # running in background.
> > >   #
> > >   . ./common/preamble
> > > -_begin_fstest auto replace scrub volume
> > > +_begin_fstest auto replace scrub volume scrub
> > 
> > The btrfs/069 has been in "scrub" group, others looks good to me.
> > 
> 
> Oh no! Would you please remove this line and merge it?
> Or, I can fix it in the upcoming PR. Or, I can reroll this
> patch.
> Thank you!

I'll remove it when I merge it, don't worry.

Thanks,
Zorro

> 




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux