On Tue, Dec 13, 2022 at 04:32:34PM +0100, David Disseldorp wrote: > On Tue, 13 Dec 2022 22:41:52 +0800, Zorro Lang wrote: > > > Hmm.. That's weird, both xfs_info and xfs_spaceman are from xfsprogs > > package. If someone xfsprogs version doesn't hasve provide xfs_spaceman, > > why its xfs_info would like to call that? What xfsprogs do you use? > > I have a hacky bunch of scripts that use Dracut to generate an > initramfs image with minimal dependencies for xfstests alongside the > test kernel: https://github.com/rapido-linux/rapido > > The rapido dependency list is now fixed, but I figured that this change > makes sense given the other scattered _require_X checks for xfsprogs > binaries. Feel free to drop this change if you don't agree. We should let xfsprogs decide how xfs_info works. xfs_info doesn't always depends on xfs_spaceman, old xfs_info might use xfs_db or other things to get xfs info, and I don't know if it'll be changed to use other command in the future again. So this change will cause all cases which call _require_acl_get_max will notrun on old (maybe future) xfsprogs which doesn't has xfs_spaceman "info" command. I think that's not what we want, so I'd like to drop this patch. Thanks for your understanding. Thanks, Zorro > > Cheers, David >
