On Tue, Dec 13, 2022 at 12:08:18AM +0100, David Disseldorp wrote:
> For xfs, _acl_get_max() calls xfs_info which in turn calls
> "xfs_spaceman -c info ...".
>
> Without this change, xfs_spaceman absence results in:
> --- tests/generic/026.out
> +++ /home/david/xfstests/results//generic/026.out.bad
> @@ -1,9 +1,11 @@
> QA output created by 026
> +/usr/sbin/xfs_info: line 44: xfs_spaceman: command not found
Hmm.. That's weird, both xfs_info and xfs_spaceman are from xfsprogs
package. If someone xfsprogs version doesn't hasve provide xfs_spaceman,
why its xfs_info would like to call that? What xfsprogs do you use?
Thanks,
Zorro
>
> === Test out large ACLs ===
> +/usr/sbin/xfs_info: line 44: xfs_spaceman: command not found
> 1 below acl max
> acl max
> ...
>
> Signed-off-by: David Disseldorp <ddiss@xxxxxxx>
> ---
> common/attr | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/common/attr b/common/attr
> index cce4d1b2..a94c5e4b 100644
> --- a/common/attr
> +++ b/common/attr
> @@ -57,6 +57,9 @@ _acl_get_max()
>
> _require_acl_get_max()
> {
> + # _acl_get_max -> xfs_info -> xfs_spaceman
> + [ "$FSTYP" == "xfs" ] && _require_xfs_spaceman_command "info"
> +
> if [ $(_acl_get_max) -eq 0 ]; then
> _notrun "$FSTYP does not define maximum ACL count"
> fi
> --
> 2.35.3
>
