Re: [PATCH] btrfs: remove 'seek' group from btrfs/007

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Sep 02, 2022 at 10:00:30AM +0800, Zorro Lang wrote:
> On Thu, Sep 01, 2022 at 05:12:25PM +0100, fdmanana@xxxxxxxxxx wrote:
> > From: Filipe Manana <fdmanana@xxxxxxxx>
> > 
> > btrfs/007 does not test lseek, it tests send/receive and lseek is not
> > exercised anywhere in this test. So just remove it from the 'seek' group.
> > 
> > Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx>
> > ---
> 
> This 'seek' group is brought in by below commit:
> 
>   commit 6fd9210bc97710f81e5a7646a2abfd11af0f0c28
>   Author: Christoph Hellwig <hch@xxxxxx>
>   Date:   Mon Feb 18 10:05:03 2019 +0100
> 
>       fstests: add a seek group
> 
> So I'd like to let Christoph help to double check it.

It's quite obvious from the test itself that it tests only send/receive,
which is mentioned in the changelog. The commit adding the seek group
does not provide any rationale so it's hard to argue but as it stands
now the 'seek' group should not be there.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux