Re: [PATCH] btrfs: remove 'seek' group from btrfs/007

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Fri, Sep 02, 2022 at 11:44:24AM +0200, David Sterba wrote:
> >   commit 6fd9210bc97710f81e5a7646a2abfd11af0f0c28
> >   Author: Christoph Hellwig <hch@xxxxxx>
> >   Date:   Mon Feb 18 10:05:03 2019 +0100
> > 
> >       fstests: add a seek group
> > 
> > So I'd like to let Christoph help to double check it.
> 
> It's quite obvious from the test itself that it tests only send/receive,
> which is mentioned in the changelog. The commit adding the seek group
> does not provide any rationale so it's hard to argue but as it stands
> now the 'seek' group should not be there.

Probably.  Unless it somehow exercised seeks through the userspace
seek code I can't see any good rationale for this addition, and the
patch was far too long ago for me to remember.



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux