On Fri, Sep 02, 2022 at 10:11:37AM +0800, Zorro Lang wrote: > Better to make sure we swapoff this file in _cleanup() too, to avoid it affect > later testing if something suddently kill the testing. Others looks good to me, > welcome more review from btrfs. You can assume an implicit ack for any btrfs tests when it's sent by a person with history of existing fstests and/or btrfs commits. A review would be desirable but I'd say it would hardly find any problems, typically the one who writes the kernel patch has a test script that is then transformed to the test case so you can also expect a real testing. Speaking for the btrfs developer group, we'd rather see slightly imperfect or not formally reviewed patch in fstests suite as we'd catch any breakage once it's pushed to git. We have daily update and test loops and we'll notice, also we know how to revert commits or disable tests if needed. Holding back sent patches is counterproductive. Thanks.
